refactor(v2): add title attribute to anchor link #2066
Conversation
lex111
added
the
pr: polish
|
Deploy preview for docusaurus-2 ready! Built with commit 4dcaa4d |
|
Deploy preview for docusaurus-preview ready! Built with commit 4dcaa4d |
|
Deploy preview for docusaurus-2 ready! Built with commit 47ea13b |
|
Deploy preview for docusaurus-preview ready! Built with commit 47ea13b |
|
Deploy preview for docusaurus-2 ready! Built with commit 43cd394 |
|
Deploy preview for docusaurus-preview ready! Built with commit 43cd394 |
| tabIndex="-1" | ||
| className="hash-link" | ||
| href={`#${id}`} | ||
| title="Direct link to heading"> |
There was a problem hiding this comment.
Can we check in react-axe or something if this will cause duplicated title issue on a11y ?
Like every a title will be this Direct link to heading
Maybe
| title="Direct link to heading"> | |
| title={`Direct link to heading with id` + id}> |
There was a problem hiding this comment.
Can we check in react-axe or something if this will cause duplicated title issue on a11y ?
No, there will not be such an issue. I checked via the axe extension.
There was a problem hiding this comment.
Ok we're good to merge this then
Motivation
Add missing attr to link.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan