feat(v2): support prefers-color-scheme & fix dark mode FOUC on refresh #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
commented
Nov 30, 2019
| @@ -62,9 +63,6 @@ | |||
|
|
|||
| :global(.react-toggle--disabled) { | |||
| cursor: not-allowed; | |||
| opacity: 0.5; | |||
There was a problem hiding this comment.
Removed this so it doesnt look transparent on first paint.
Cursor not allowed is needed for a11y, because anyway the toggle can't be clicked until reactjs load
|
Deploy preview for docusaurus-2 ready! Built with commit 65f7761 |
|
Deploy preview for docusaurus-preview ready! Built with commit 65f7761 |
endiliey
changed the title
endiliey
added
the
feature
endiliey
changed the title
yangshun
approved these changes
Nov 30, 2019
endiliey
added
pr: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1995
Before this PR, notice the FOUC
Also have prefer color scheme.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
You can also try it on netlify :)
https://deploy-preview-2069--docusaurus-2.netlify.com/
cc @lex111 in case you want to give this a try. Seems that this should fit all of our use case
Extra notes
isClientcontext is needed because we need to do two pass renderingWhy do we need two pass rendering ?
For full reasoning, please check the whole thread starting from this comment #2057 (comment)
I tweaked the CSS such that it looks very perfect now.