Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v1): add key to versions.map in versions.js #2087

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

FeynmanDNA
Copy link
Contributor

I noticed the v1 examples versions.js when calling map function does not provide a key.

So i added the key prop to packages/docusaurus-1.x/examples/versions/pages/en/versions.js

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 5, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 5216ccd

https://deploy-preview-2087--docusaurus-2.netlify.com

@yangshun yangshun changed the title fix(v1) add react key to versions.map in versions.js fix(v1): add key to versions.map in versions.js Dec 5, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 5216ccd

https://deploy-preview-2087--docusaurus-preview.netlify.com

@yangshun yangshun added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Dec 5, 2019
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yangshun yangshun merged commit 381ed59 into facebook:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants