Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): add missing hyphen in color generator #2106

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Dec 9, 2019

Motivation

CSS vars starts with two hyphens.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

image

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 9, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 671e8a9

https://deploy-preview-2106--docusaurus-preview.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 671e8a9

https://deploy-preview-2106--docusaurus-2.netlify.com

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@endiliey endiliey merged commit 172f071 into facebook:master Dec 9, 2019
@yangshun
Copy link
Contributor

yangshun commented Dec 9, 2019

🙈 This is embarrassing. Thanks @lex111!

@endiliey endiliey added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants