feat(v2): lazy load algolia css so its not render blocking #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
pr: polish
|
Deploy preview for docusaurus-2 ready! Built with commit cba7199 |
|
Deploy preview for docusaurus-preview ready! Built with commit cba7199 |
yangshun
approved these changes
Dec 15, 2019
packages/docusaurus-theme-search-algolia/src/theme/SearchBar/index.js
Outdated
Show resolved
Hide resolved
endiliey
added
the
status: don't merge yet
endiliey
removed
the
status: don't merge yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Maybe this is an overkill. Feel free to close if this isnt a good idea.
As we all know, we now single extract css into one css file. And CSS is actually render breaking.
I made a small optimization such that the algolia css is forced to be its own chunk (also better caching in future), and is only loaded when we hover or click the search bar (just like what we did with the JS). This reduce our initial critical CSS size by around 20% and should make the render slightly faster.
The hiccups is still infima css which is 17kb gzipped.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Algolia should still be working on netlify