Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix typo in remark-admonitions example #2343

Merged
merged 2 commits into from Feb 29, 2020

Conversation

hassanfarid
Copy link
Contributor

Motivation

Removing typo errors, making documentation more useful.

Related PRs

Not required.

@facebook-github-bot
Copy link
Contributor

Hi @hassanfarid!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Feb 28, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 68530eb

https://deploy-preview-2343--docusaurus-2.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 28, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hassanfarid could you please fix the typo in the file of the master version docs? https://github.com/facebook/docusaurus/blob/master/website/docs/markdown-features.mdx

@yangshun yangshun changed the title Fixed typo in the example docs(v2): fix typo in the example Feb 29, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the trunk example and pushed to this PR.

@yangshun yangshun changed the title docs(v2): fix typo in the example docs(v2): fix typo in remark-admonitions example Feb 29, 2020
@yangshun yangshun merged commit 7b2716e into facebook:master Feb 29, 2020
@yangshun yangshun added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants