fix(v2): add support esModule to lqip-loader #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit decedb0 |
yangshun
reviewed
May 17, 2020
|
Yes, I want to use it in my project. Merging these changes will reduce the size of the file after building with tree shaking in an environment that supports ES Modules. I think it works for Docusaurus as well. |
yangshun
added
pr: bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently
url-loaderandfile-loaderhave the optionesModuleistrueby default. So@docusaurus/lqip-loaderwill always throw an exception unless you explicitly setesModuletofalse.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Use
@docusaurus/lqip-loaderalone or withurl-loaderorfile-loaderaccording to README.md.Related PRs
Nothing.