Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): improve UX of search page #2761

Merged
merged 1 commit into from
May 17, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 17, 2020

Motivation

  • Do not open the search page if a suggestion from navbar was selected
  • Set auto focus on the input of search page (usually this is not a good practice, but in this case I think it is necessary)
  • Pluralize search results count

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label May 17, 2020
@lex111 lex111 requested a review from yangshun as a code owner May 17, 2020 12:49
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 17, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit d9cabb9

https://deploy-preview-2761--docusaurus-2.netlify.app

@yangshun yangshun merged commit 778adb2 into master May 17, 2020
@lex111 lex111 deleted the lex111/search-page-fixes branch May 17, 2020 15:33
@lex111 lex111 added this to the v2.0.0-alpha.55 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants