Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): use base url to navigate to search page #2838

Merged
merged 4 commits into from
Jun 2, 2020
Merged

fix(v2): use base url to navigate to search page #2838

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1298f8c
fix: consider baseUrl
tetunori May 29, 2020
72b319a
fix: use `useBaseUrl()`
tetunori May 30, 2020
a92d07a
Revert "fix: use `useBaseUrl()`"
tetunori Jun 1, 2020
22985fb
fix: add link to PR
tetunori Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/docusaurus-theme-search-algolia/src/theme/hooks/useSearchQuery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@

import {useHistory, useLocation} from '@docusaurus/router';
import ExecutionEnvironment from '@docusaurus/ExecutionEnvironment';
import useDocusaurusContext from '@docusaurus/useDocusaurusContext';

const SEARCH_PARAM_QUERY = 'q';

function useSearchQuery() {
const history = useHistory();
const location = useLocation();
const {siteConfig: {baseUrl} = {}} = useDocusaurusContext();

return {
searchValue:
Expand All @@ -33,7 +35,8 @@ function useSearchQuery() {
});
},
navigateToSearchPage: (searchValue) => {
history.push(`/search?q=${searchValue}`);
// Refer to https://github.com/facebook/docusaurus/pull/2838
history.push(`${baseUrl}search?q=${searchValue}`);
},
};
}
Expand Down