Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): synchronize yarn/npm command on site #2897

Merged
merged 1 commit into from Jun 6, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 6, 2020

Motivation

In order to follow dogfooding approach on our website v2.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jun 6, 2020
@lex111 lex111 requested a review from yangshun as a code owner June 6, 2020 08:00
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 6, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 545f22b

https://deploy-preview-2897--docusaurus-2.netlify.app

@lex111 lex111 added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. and removed pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Jun 6, 2020
@yangshun yangshun merged commit 36cf2ec into master Jun 6, 2020
@lex111 lex111 deleted the lex111/sync-choice-tab-for-npm2yarn branch June 7, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants