chore(v2): refactor yarn tsc to yarn build + add theme-classic watch mode #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: maintenance
|
Deploy preview for docusaurus-2 ready! Built with commit fa50e57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Classic theme is built with Babel now, so having a
tscscript for all packages is a weird naming. Let's renameyarn tsctoyarn build.Also the root command to build the packages is renamed as
yarn build:packages(yarn buildis already used currently).Also, It should be possible to use watch mode on the theme classic by using the --watch arg on babel compilation
cc @SamChou19815