fix(v2): dropdown navbar item: validation too strict #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opdown parent to have an associated link (not retrocompatible)
|
Deploy preview for docusaurus-2 ready! Built with commit 3a927a1 |
|
thanks, This will still require you to use the # workaround though... will try to see how to solve that with ReactRouter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The new validation is too strict and wouldn't allow a valid configuration where the parent dropdown item has no href/to attribute.
The config of this user, which is legit and works in former versions, wouldn't be accepted anymore:
#3067 (comment)