Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): docs version configuration: lastVersion, version.{path,label} #3357

Merged
merged 9 commits into from
Aug 28, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 28, 2020

Motivation

Implement some low hanging fruits of #3285

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Unit tests

Dogfooding in dev env and deploy previews with a special config, as it makes more sense to focus on "next version" in those contexts:

          lastVersion: isDev || isDeployPreview ? 'current' : undefined,
          versions: {
            current: {
              path: isDeployPreview ? 'next-pr' : undefined,
              label: isDeployPreview ? 'Next (PR)' : 'Next',
            },
          },

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Aug 28, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 28, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 28, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 6c06bda

https://deploy-preview-3357--docusaurus-2.netlify.app

@slorber slorber merged commit ae877f2 into master Aug 28, 2020
@lex111 lex111 deleted the slorber/versioning-configuration branch October 7, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants