fix(v2): scripts should allow unknown values #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: bug fix
|
Deploy preview for docusaurus-2 ready! Built with commit 613f20f |
|
Hi friends. I came across this PR for the same reason as the original issue. Should the documentation be updated so users know what additional attributes they can pass to scripts in |
|
yes if it's missing you can add it in our doc, just send a pr |
|
I would, if I felt I understood it well enough to properly document it. |
|
No worries, I can do it. Thanks for bringing this up! |
|
@alexfornuto Included as part of #7519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #3378
It should be possible to apply data attributes to the scripts tags
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tests