feat(v2): version dropdown before/after items + move site "All Versions" link #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
changed the title
slorber
added
pr: new feature
|
Deploy preview for docusaurus-2 ready! Built with commit 743ea33 |
lex111
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our own site navbar is becoming crowded.
Nesting the "All Versions" link inside the dropdown permits to remove more easily a useless navbar element.
I also see this as a possible way to link to older archived versions that are not in Docusaurus site anymore.
For example, the RN website has 64+ versions, but it's not manageable to keep so much versions, so we can only keep recent versions in Docusaurus, but still be able to link to older ones (published as standalone immutable sites).
cc @lex111 @Simek
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview + dogfooding