Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): embedding real source code in MDX as a code block #3558

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 8, 2020

@slorber slorber requested a review from lex111 as a code owner October 8, 2020 12:34
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 8, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 8, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Oct 8, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 7c9985b

https://deploy-preview-3558--docusaurus-2.netlify.app

Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks for figuring this out.

Comment on lines +54 to +55
"devDependencies": {
"raw-loader": "^4.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why devDependencies instead of dependencies ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants