Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): add better error message for yarn workspace/monorepo/terser issue #3619

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 21, 2020

Motivation

Help users find the issue/workaround for a weird temporary Yarn monorepo/workspace dependency resolution issue.

This way, we have less support to do until it's fixed

#3515

@slorber slorber requested a review from lex111 as a code owner October 21, 2020 11:16
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 21, 2020
@slorber slorber changed the title Helpful error message when monorep Terser issue happens refactor(v2): add better error message for yarn workspace/monorepo/terser issue Oct 21, 2020
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Oct 21, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Oct 21, 2020

Deploy preview for docusaurus-2 ready!

Built with commit f7fccb4

https://deploy-preview-3619--docusaurus-2.netlify.app

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@slorber slorber merged commit 91256d4 into master Oct 21, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
@slorber slorber deleted the slorber/help-monorepo-terser-issue branch August 17, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants