Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): wrap code blocks on print #3637

Merged
merged 1 commit into from
Oct 25, 2020

Conversation

haivp3010
Copy link
Contributor

Motivation

Currently code blocks with scrollbars are cut off on print. They should be wrapped instead.
Fixes #3633.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Before:

Screen Shot 2020-10-26 at 00 20 44

After:

Screen Shot 2020-10-26 at 00 21 45

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 25, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit d1361f9

https://deploy-preview-3637--docusaurus-2.netlify.app

@lex111 lex111 merged commit 85971fd into facebook:master Oct 25, 2020
@lex111
Copy link
Contributor

lex111 commented Oct 25, 2020

@haivp3010 thanks!

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 26, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text not fully shown on print when having code blocks with scroll bars.
5 participants