Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add skip to content link #3640

Merged
merged 1 commit into from
Oct 26, 2020
Merged

feat(v2): add skip to content link #3640

merged 1 commit into from
Oct 26, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Oct 25, 2020

Motivation

Improve keyboard users experience by adding a shortcut to navigate to main content.

This feature is described in more detail here https://www.w3.org/TR/WCAG20-TECHS/G1.html and here https://webaim.org/techniques/skipnav/

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan.

  • Go to the preview website.
  • Hit the tab key
  • Press the tab key again to make sure the focus is on main content.

Demo:

ezgif com-gif-maker (9)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: new feature This PR adds a new API or behavior. label Oct 25, 2020
@lex111 lex111 requested a review from slorber as a code owner October 25, 2020 22:28
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 25, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 67ad327

https://deploy-preview-3640--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Oct 26, 2020

TIL, didn't know about this technique 🤪

@slorber slorber merged commit a64a34f into master Oct 26, 2020
@lex111 lex111 deleted the lex111/skip-navigation branch October 26, 2020 22:05
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
@kimbaudi
Copy link

kimbaudi commented Dec 1, 2020

I just discovered this component today. I was wondering what it does and now I know. cool stuff 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants