Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): update the link of joi #3644

Merged
merged 1 commit into from
Oct 27, 2020
Merged

docs(v2): update the link of joi #3644

merged 1 commit into from
Oct 27, 2020

Conversation

kenve
Copy link
Contributor

@kenve kenve commented Oct 27, 2020

Motivation

Update documentation for migrating hapi/joi to joi. reference #3638.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot
Copy link
Contributor

Hi @kenve!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@slorber
Copy link
Collaborator

slorber commented Oct 27, 2020

LGTM thanks!

Can you sign the required CLA please? (the bot might take some time to add the label, will wait)

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit ece8cd1

https://deploy-preview-3644--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 27, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 merged commit 4f64da8 into facebook:master Oct 27, 2020
@lex111
Copy link
Contributor

lex111 commented Oct 27, 2020

@kenve thanks!

@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants