Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): improve regex matching code-block title #3685

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

hong4rc
Copy link
Contributor

@hong4rc hong4rc commented Nov 4, 2020

Motivation

#3671 can't work with Safari, this PR to fix it(still quickly+sort code)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tested with Safari
image

Related PRs

#3671

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 8159621

https://deploy-preview-3685--docusaurus-2.netlify.app

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good this time.

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 5, 2020
@slorber slorber merged commit f8a6b39 into facebook:master Nov 5, 2020
@hong4rc hong4rc deleted the patch-2 branch November 5, 2020 12:08
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants