docs(v2): normalize showcase preview images height #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 50cd235 |
|
I don't have good eyes, can't see any difference 😅 can you help me understand which card is affected exactly? |
|
@slorber Tasit is the example which I want to highlight on the screenshot, but there are some slight height reduction to other previews too. 🙂 |
|
thanks, make sense now :) |
slorber
added
the
pr: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently on the V2 showcase page website preview images height is not restricted in any way which in some cases results in stretching preview cards too much.
This PR add small CSS tweak to the card image wrapper so it won't exceed height of
175px. The height was chosen arbitrary based on the current available images in the showcase directory. Image still can have smaller height that decaled and it will not affect the presentation.The changeset also includes a removal of unused hook from the showcase page file.
Before
After
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Changes has been tested on the Docusuaurs V2 website locally.
Related PRs
No.