Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add support for sync to npm2yarn tabs #3705

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 6, 2020

Motivation

Add support for tab choices synchronization to npm/yarn tabs (see https://v2.docusaurus.io/docs/markdown-features/#syncing-tab-choices for more details).

I did it via option to make the plugin behavior more flexible.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: new feature This PR adds a new API or behavior. label Nov 6, 2020
@lex111 lex111 requested a review from slorber as a code owner November 6, 2020 11:53
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 6, 2020
@netlify
Copy link

netlify bot commented Nov 6, 2020

Deploy preview for docusaurus-2 ready!

Built with commit cbf2139

https://deploy-preview-3705--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Nov 6, 2020

good idea 👍

@slorber slorber merged commit 3aeb90f into master Nov 6, 2020
@lex111 lex111 deleted the lex111/sync-npm2yarn branch November 6, 2020 17:01
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants