Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): add support for non-ASCII chars in anchor link scroll #3724

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 11, 2020

Motivation

Fixes #2901

Also, improving the work of the hideable header when changing the anchor (hash) - the header was not always hidden for some reason so it is fixes #2907.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See #2901 (comment)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Nov 11, 2020
@lex111 lex111 requested a review from slorber as a code owner November 11, 2020 12:15
@netlify
Copy link

netlify bot commented Nov 11, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 7483380

https://deploy-preview-3724--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 11, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 12, 2020

LGTM

@slorber slorber merged commit 702fc15 into master Nov 12, 2020
@lex111 lex111 deleted the lex111/anchor-link-issie branch November 13, 2020 22:58
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor links go to a scroll position that is slightly lower Cannot move to another page's anchor
3 participants