Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add Inline SVG color override example #3737

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Nov 13, 2020

Motivation

Currently Inline SVGs section in docs is a stub. This PR adds the example usage, which shows how user can override the single color, or even many colors of inlined SVG image, based on the currently selected theme by user.

At the beginning I want to utilize the class in the CSS selector, but it requires editing a SVG file and the class name is processed (belly became docusaurus_svg__belly), so I have decided to just use fill as selector (for the simplicity, instead of [class*='belly']).

Have you read the Contributing Guidelines on pull requests?

You

Test Plan

inline

Related PRs

No.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 13, 2020
@netlify
Copy link

netlify bot commented Nov 13, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit ce8ad03

https://deploy-preview-3737--docusaurus-2.netlify.app

@slorber slorber changed the title chore(v2): add Inline SVG color override example docs(v2): add Inline SVG color override example Nov 13, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 13, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 13, 2020

LGTM 👍

@slorber slorber merged commit 74ee8f6 into facebook:master Nov 13, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants