Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): fix mismatch peer dependency in MDX loader #3753

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 14, 2020

Motivation

In all other packages, we have React version 16.8.4 specified.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner November 14, 2020 22:37
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 14, 2020
@netlify
Copy link

netlify bot commented Nov 14, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 307178d

https://deploy-preview-3753--docusaurus-2.netlify.app

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 16, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 16, 2020

thanks

@slorber slorber merged commit cb55a2b into master Nov 16, 2020
@lex111 lex111 deleted the lex111/fix-peer-dep-react-mdx-loader branch November 16, 2020 13:27
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants