fix(v2): codesandbox generated examples should use published init package #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sammychinedu2ky had to change the behavior back finally 😅 |
|
Deploy preview for docusaurus-2 ready! Built with commit 7a3da54 |
|
Size Change: +22 B (0%) Total Size: 152 kB ℹ️ View Unchanged
|
slorber
added a commit
that referenced
this pull request
Jul 22, 2021
…kage (#3760) * Fix codesandbox generated examples to use published init script instead of local one * Fix codesandbox generated examples to use published init script instead of local one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use the local "init" script, otherwise we may end up with upcoming config options that are not supported by current version.
See related Codesandbox error I just had due to this too-early option:
CodeSandbox will use the latest published version so we must ensure that we generate a project compatible with that version.
For this reason it's preferable to update the code sandbox examples just after a release (instead of before, like I initially thought)