Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): fix several npm warnings #3766

Merged
merged 1 commit into from
Nov 17, 2020
Merged

chore(v2): fix several npm warnings #3766

merged 1 commit into from
Nov 17, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 17, 2020

Motivation

Just fix various npm warnings about peer dependencies.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Logs

Diff changes:

warning " > eslint-config-airbnb@18.1.0" has incorrect peer dependency "eslint@^5.16.0 || ^6.8.0".
warning " > eslint-config-airbnb@18.1.0" has incorrect peer dependency "eslint-plugin-react-hooks@^2.5.0 || ^1.7.0".
warning "eslint-config-airbnb > eslint-config-airbnb-base@14.1.0" has incorrect peer dependency "eslint@^5.16.0 || ^6.8.0".
warning " > eslint-plugin-jsx-a11y@6.2.3" has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6".
warning "eslint-plugin-jsx-a11y > axobject-query@2.1.1" has incorrect peer dependency "eslint@^5 || ^6".
- warning " > workspace-aggregator-64c1ce2e-ccc2-4213-bcef-41c7767f9714@" has incorrect peer dependency "stylelint-copyright@^2.0.0".
- warning " > @docusaurus/mdx-loader@2.0.0-alpha.66" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
- warning " > @docusaurus/lqip-loader@2.0.0-alpha.66" has unmet peer dependency "file-loader@*".
- warning " > @docusaurus/lqip-loader@2.0.0-alpha.66" has unmet peer dependency "sharp@*".
- warning "workspace-aggregator-64c1ce2e-ccc2-4213-bcef-41c7767f9714 > @docusaurus/mdx-loader > file-loader@6.2.0" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
- warning "workspace-aggregator-64c1ce2e-ccc2-4213-bcef-41c7767f9714 > @docusaurus/mdx-loader > url-loader@4.1.1" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
- warning "workspace-aggregator-64c1ce2e-ccc2-4213-bcef-41c7767f9714 > @docusaurus/migrate > jscodeshift@0.10.0" has unmet peer dependency "@babel/preset-env@^7.1.6".
warning "workspace-aggregator-64c1ce2e-ccc2-4213-bcef-41c7767f9714 > @docusaurus/plugin-ideal-image > @endiliey/react-ideal-image@0.0.11" has unmet peer dependency "prop-types@>=15".
warning "workspace-aggregator-64c1ce2e-ccc2-4213-bcef-41c7767f9714 > @docusaurus/theme-bootstrap > bootstrap@4.4.1" has unmet peer dependency "jquery@1.9.1 - 3".
warning "workspace-aggregator-64c1ce2e-ccc2-4213-bcef-41c7767f9714 > @docusaurus/theme-bootstrap > bootstrap@4.4.1" has unmet peer dependency "popper.js@^1.16.0".
warning "workspace-aggregator-64c1ce2e-ccc2-4213-bcef-41c7767f9714 > docusaurus-2-website > raw-loader@4.0.1" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".

Related PRs

@lex111 lex111 requested a review from slorber as a code owner November 17, 2020 08:44
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 17, 2020
@netlify
Copy link

netlify bot commented Nov 17, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 8d30e6e

https://deploy-preview-3766--docusaurus-2.netlify.app

@github-actions
Copy link

Size Change: +22 B (0%)

Total Size: 152 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -1 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.84 kB +2 B (0%)
website/build/main.********.js 108 kB +21 B (0%)
website/build/styles.********.css 17.4 kB 0 B

compressed-size-action

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 17, 2020
@slorber slorber merged commit d5c8a0c into master Nov 17, 2020
@lex111 lex111 deleted the lex111/fix-npm-warn branch November 17, 2020 15:00
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
@@ -119,7 +119,7 @@
"typescript": "^3.9.5"
},
"peerDependencies": {
"stylelint-copyright": "^2.0.0"
"stylelint-copyright": "2.0.0-alpha.66"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lex111

@Simek noticed that. this version didn't get bumped to alpha 68 with latest release, I believe it's because the root package is not a monorepo published package.

Is there a good reason for this change or should we revert?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I didn’t know about it, then we will get the same warning, although it’s probably better than what we have now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just remove it?

#3800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants