Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v2): fix statements background, update footer background #3769

Merged
merged 1 commit into from
Nov 17, 2020
Merged

docs(v2): fix statements background, update footer background #3769

merged 1 commit into from
Nov 17, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Nov 17, 2020 •
edited
Loading

Motivation

This PR introduces small design changes to the V2 website:

  • fixes the users statements background (previously used CSS variable do not exist anymore in Infima)
  • fixes the CSS warnings according to usage of rgb with a transparency channel
  • updates the "dark" footer background to match the color used for the homepage hero section (the shade change is subtle)

Preview

Screenshot 2020-11-17 151010

Screenshot 2020-11-17 151021

Comparison

Screenshot 2020-11-17 151942

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Changes have been testes locally, by running the Docusuaurs V2 website.

Related PRs

No.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 17, 2020
@netlify
Copy link

netlify bot commented Nov 17, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 41423ad

https://deploy-preview-3769--docusaurus-2.netlify.app

@lex111 lex111 merged commit 5872bbc into facebook:master Nov 17, 2020
@lex111
Copy link
Contributor

lex111 commented Nov 17, 2020

@Simek thanks!

@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 17, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 lex111 approved these changes

@slorber slorber Awaiting requested review from slorber

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Milestone
v2.0.0-alpha.68
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Simek @lex111 @facebook-github-bot