chore(v2): prepare v2.0.0.alpha-68 release #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit d2fd143 |
|
Size Change: +1.49 kB (0%) Total Size: 153 kB
ℹ️ View Unchanged
|
lex111
reviewed
Nov 18, 2020
|
|
||
| **TLDR**: you need to mark them as public, publish, and mark them back as private | ||
|
|
||
| v1 packages have been marked as `private: true` on purpose. This is because lerna will publish ALL (v1+v2) packages with the lerna-publish command. Unfortunately it seems therre is no way to tell it to ignore v1 packages while publishing v2. During a long time, we published all these packages using the @next dist tag: `yarn lerna publish 2.0.0-alpha.41 --dist-tag next --exact` But it cause problems because v2 packages will then all need @next during npm/yarn installs, confusing some users (https://github.com/facebook/docusaurus/issues/3755) We made the v1 packages private so that lerna publish won't publish them, so that we can publish v2 packages under latest dist tag, without creating v1 upgrades that people will be notified abut. |
There was a problem hiding this comment.
Great explanation 👍
Can we mark new versions with two tags, latest and next? It seems that they did it before.
There was a problem hiding this comment.
thanks.
Actually I think it's a mistale, and it's one single badly named tag 😓
I'm actually removing all the next tags so that the @Docusaurus packages are all on latest
There was a problem hiding this comment.
To keep a reference somewhere, I removed the v2 tags with the following command:
yarn lerna exec --no-private 'yarn tag remove $LERNA_PACKAGE_NAME next,latest'
yarn lerna exec --no-private 'yarn tag remove $LERNA_PACKAGE_NAME next'
The --no-private ensure that v1 packages are not untagged (because they are now private)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Release v2.0.0.alpha-68
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Note: alpha67 was a failed release (#3778)