feat(v2): add baseUrlIssueBanner configuration to disable banner #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 130e211 |
|
Size Change: +190 B (0%) Total Size: 154 kB
ℹ️ View Unchanged
|
lex111
approved these changes
Nov 23, 2020
packages/docusaurus/src/client/baseUrlIssueBanner/BaseUrlIssueBanner.tsx
Outdated
Show resolved
Hide resolved
lex111
approved these changes
Nov 23, 2020
|
@slorber thanks! |
aleccool213
reviewed
Dec 23, 2020
| */ | ||
|
|
||
| .baseUrlIssueBanner { | ||
| display: none; |
There was a problem hiding this comment.
Curious as to why this was hidden from view? Getting this error and it never showed which caused me to come here :/
|
This is hidden on purpose because if the css can load it means baseurl is
correctly configured.
It's not clear to me what error you have exactly
Le mer. 23 déc. 2020 à 17:17, Alec Brunelle <notifications@github.com> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In packages/docusaurus/src/client/baseUrlIssueBanner/styles.module.css
<#3802 (comment)>:
> @@ -0,0 +1,10 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+.baseUrlIssueBanner {
+ display: none;
Curious as to why this was hidden from view? Getting this error and it
never showed which caused me to come here :/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3802 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW6PT7S6SZ4UKH2IITGOTSWIJ2VANCNFSM4T7XR6QQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Better naming refactor + add option to disable the baseUrl help banner.
This banner is not compatible with users with strict CSP policies (#3584 (comment))