Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add wasp to showcase #3832

Merged
merged 3 commits into from Nov 30, 2020
Merged

docs(v2): Add wasp to showcase #3832

merged 3 commits into from Nov 30, 2020

Conversation

matijaSos
Copy link
Contributor

Motivation

Adding a project (Wasp) that is built with Docusaurus v2.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Related PRs

@facebook-github-bot
Copy link
Contributor

Hi @matijaSos!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Nov 27, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 1b4625d

https://deploy-preview-3832--docusaurus-2.netlify.app

@matijaSos matijaSos changed the title Update users.js Added wasp-lang to user showcase. Nov 27, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 27, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber
Copy link
Collaborator

slorber commented Nov 27, 2020

Thanks

I think you interverted Wasp and Wisdom no?

The PR is failing but it's not your fault, will fix this asap.

@slorber
Copy link
Collaborator

slorber commented Nov 27, 2020

The PR issue on our side should be fixed if you update your branch with upstream changes.

However you still seem to have interverted 2 sites's data, and the uploaded filename is wrong

image

@slorber slorber changed the title Added wasp-lang to user showcase. docs(v2): Add wasp to showcase Nov 30, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 30, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 30, 2020

Just updated your PR, now ready to merge

@matijaSos
Copy link
Contributor Author

@slorber thanks a lot for fixing it! I was just about to do it and then noticed you've just done it :)

@slorber slorber merged commit 139b668 into facebook:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants