feat(V2): add custom wrapper class to SearchPage, fix title #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 2e73641 |
|
Hi, PR should pass after updating your branch, it's an error on master I fixed |
Simek
force-pushed
the
add-search-page-wrapper-class
branch
from
8750f4a
to
2246073
Compare
lex111
reviewed
Nov 27, 2020
| @@ -294,7 +294,7 @@ function Search() { | |||
| }, [searchValue]); | |||
|
|
|||
| return ( | |||
| <Layout title={getTitle()}> | |||
| <Layout title={getTitle()} wrapperClassName="search-results-wrapper"> | |||
There was a problem hiding this comment.
search-page-wrapper is better suited because "results" can only refer to a specific section of this page.
|
I have decided also to add small fix for the title of the Currently the page title do not follow the general pattern which includes
Preview
|
Simek
changed the title
lex111
approved these changes
Nov 27, 2020
|
@Simek thanks! |
This was referenced Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there is not possible to customize the
SearchPagestyling without swizzling the component.This PR adds the custom wrapper class name to the
SearchPage, so it will be possible to add custom styles which only apply to this page.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Local run of Docusaurus V2 website.
Preview
Related PRs
No.