Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Fixed Typo: Hided => Hidden #3851

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Conversation

woodrufs
Copy link
Contributor

@woodrufs woodrufs commented Dec 1, 2020

Fixed typo in section about the hideable sidebar. 'hided' is used instead of 'hidden'.

Motivation

Recently started familiarizing myself with Docusaurus. I was reading the documentation and noticed the typo.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Simple type fix.

Fixed typo in section about the hideable sidebar. 'hided' is used instead of 'hidden'.
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 1, 2020
@netlify
Copy link

netlify bot commented Dec 1, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 3d19f8b

https://deploy-preview-3851--docusaurus-2.netlify.app

@woodrufs woodrufs marked this pull request as ready for review December 1, 2020 03:17
@github-actions
Copy link

github-actions bot commented Dec 1, 2020

Size Change: +23 B (0%)

Total Size: 157 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB +1 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.86 kB +1 B
website/build/main.********.js 113 kB +21 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 1, 2020
@slorber
Copy link
Collaborator

slorber commented Dec 1, 2020

LGTM thanks ;)

@woodrufs
Copy link
Contributor Author

woodrufs commented Dec 1, 2020

Thanks for your hard work on this @slorber. I love this tool!

@slorber
Copy link
Collaborator

slorber commented Dec 1, 2020

thanks 👍

Commited on your pr to trigger CI, as we had some CI issues

@slorber slorber changed the title Fixed Typo: Hided => Hidden docs(v2): Fixed Typo: Hided => Hidden Dec 1, 2020
@slorber slorber merged commit aff1703 into facebook:master Dec 1, 2020
@github-actions
Copy link

github-actions bot commented Dec 1, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 70
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3851--docusaurus-2.netlify.app/classic/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants