Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix navbar items issue on Windows? #3922

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Dec 14, 2020

Motivation

Fix weird theme alias issue on Windows:
https://github.com/facebook/docusaurus/runs/1552317907

image

On Windows, the aliases are created in a different order and can shadow each others:

image

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

CI

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 14, 2020
@slorber slorber requested a review from lex111 as a code owner December 14, 2020 19:14
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 14, 2020
@github-actions
Copy link

github-actions bot commented Dec 14, 2020

Size Change: +21 B (0%)

Total Size: 152 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB +1 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.8 kB 0 B
website/build/main.********.js 108 kB +20 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Dec 14, 2020

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: f49ac68

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fd7be4273fed70009be90f7

😎 Browse the preview: https://deploy-preview-3922--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 14, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 73
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3922--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit 6703f84 into master Dec 14, 2020
@slorber slorber deleted the slorber/fix-windows-navbar-item-error branch August 17, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants