Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Fix invalid json #3952

Merged
merged 2 commits into from
Dec 25, 2020
Merged

docs(v2): Fix invalid json #3952

merged 2 commits into from
Dec 25, 2020

Conversation

oze4
Copy link
Contributor

@oze4 oze4 commented Dec 24, 2020

Motivation

It ain't much, but it's honest work.

Have you read the Contributing Guidelines on pull requests?

Have you read JSON For Beginners? 馃檭 sarcasm

Test Plan

Where I come from we test in prod.

Related PRs

I'm the first person to ever discover such a bug. So, no.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 24, 2020
@netlify
Copy link

netlify bot commented Dec 24, 2020

鉁旓笍 Deploy preview for docusaurus-2 ready!
Built without sensitive environment variables

馃敤 Explore the source changes: bdb1187

馃攳 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fe5ff816402c60008941995

馃槑 Browse the preview: https://deploy-preview-3952--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 24, 2020

鈿★笍 Lighthouse report for the changes in this PR:

Category Score
馃煚 Performance 71
馃煝 Accessibility 99
馃煝 Best practices 100
馃煝 SEO 100
馃煝 PWA 95

Lighthouse ran on https://deploy-preview-3952--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Dec 24, 2020

Size Change: +9 B (0%)

Total Size: 155 kB

鈩癸笍 View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -2 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.81 kB 0 B
website/build/main.********.js 111 kB +11 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@lex111 lex111 merged commit 2791ccc into facebook:master Dec 25, 2020
@lex111
Copy link
Contributor

lex111 commented Dec 25, 2020

@oze4 this is actually JS, not JSON, but thanks for the fix!

@slorber slorber changed the title Fix invalid json docs(v2): Fix invalid json Dec 31, 2020
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 31, 2020
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants