Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): install Crowdin cli through npm package #4030

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jan 12, 2021

Motivation

The Crowdin CLI is now published as an npm package, much easier to install on CI envs like Netlify

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

CI works

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 12, 2021
@slorber slorber requested a review from lex111 as a code owner January 12, 2021 14:46
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 12, 2021
@netlify
Copy link

netlify bot commented Jan 12, 2021

✔️ [V1] Deploy preview success

🔨 Explore the source changes: 8a10f22

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-1/deploys/5ffdb65605d6a8000772fbed

😎 Browse the preview: https://deploy-preview-4030--docusaurus-1.netlify.app

@github-actions
Copy link

Size Change: 0 B

Total Size: 26.8 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.8 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.87 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Jan 12, 2021

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: 8a10f22

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ffdb656bf162d0007af5053

😎 Browse the preview: https://deploy-preview-4030--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 93
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4030--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit 20b6997 into master Jan 12, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/crowdin-cli-npm branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants