fix(v2): avoid misuse section tag in blog posts #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 28.9 kB ℹ️ View Unchanged
|
|
[V1] Deploy preview success Built with commit 239c98c |
|
Deploy preview for docusaurus-2 ready! Built with commit 239c98c |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4147--docusaurus-2.netlify.app/classic/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I think we'd better use a regular
divinstead ofsectiontag for blog post content, as we currently have HTML error like this:This is because
sectionrequires mandatory headings (hX). So therefore wise to opt out of using this tag as we cannot guarantee that this rule will be followed.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Validator's happy.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)