Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add japanese translations #4303

Merged
merged 1 commit into from
Mar 1, 2021
Merged

feat(v2): add japanese translations #4303

merged 1 commit into from
Mar 1, 2021

Conversation

ykzts
Copy link
Contributor

@ykzts ykzts commented Feb 26, 2021

Motivation

Add a Japanese translation for Japanese users.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Skip.

Related PRs

Skip.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 26, 2021
@netlify
Copy link

netlify bot commented Feb 26, 2021

@netlify
Copy link

netlify bot commented Feb 26, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 9a347bc

https://deploy-preview-4303--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 26, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4303--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Feb 26, 2021

Size Change: 0 B

Total Size: 532 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.1 kB 0 B
website/build/assets/js/main.********.js 359 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.4 kB 0 B

compressed-size-action

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Feb 28, 2021
@slorber
Copy link
Collaborator

slorber commented Feb 28, 2021

thanks, LGTM :)

Just revert the changes related to lastUpdatedAtBy as they are not really related to japanese

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber merged commit 99d8399 into facebook:master Mar 1, 2021
@ykzts ykzts deleted the ja-translations branch March 1, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants