refactor(v2): format post date using Intl #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
the
pr: polish
|
[V1] Deploy preview success Built with commit 0ae6adc |
|
Deploy preview for docusaurus-2 ready! Built with commit 0ae6adc |
lex111
force-pushed
the
lex111/format-post-date-intl
branch
from
3d49a04
to
3c28e32
Compare
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4344--docusaurus-2.netlify.app/classic/ |
|
Size Change: -1 B (0%) Total Size: 532 kB ℹ️ View Unchanged
|
slorber
reviewed
Mar 4, 2021
| @@ -23,6 +23,8 @@ | |||
| "escape-string-regexp": "^4.0.0", | |||
| "fs-extra": "^9.1.0", | |||
| "gray-matter": "^4.0.2", | |||
| "intl": "^1.2.5", | |||
| "intl-locales-supported": "^1.8.12", | |||
There was a problem hiding this comment.
so, it seems deprecated but seems safe in our case 🤪
There was a problem hiding this comment.
Hmm, didn't know about it, but this is a temporary solution until we set v14 as the minimum version of Node.
|
Looks great thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed earlier, we'd better format the date using the Intl API. Since the current minimum version of Node.js does not offer full ICU support, we will use the polyfill
Intl, which we will remove when moving to Node v14.This will not affect on final client bundle size as formatting doing on during prerendering.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)