Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): set theme color mode for SSR #4383

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 10, 2021

Motivation

Based on "bug report" from Discord chat.

Indeed, since the user defines site preferred color mode in config file, we can take this information to set the color mode (used by useTheme) during site build.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Try use colorMode.defaultMode with dark value and build the site.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Mar 10, 2021
@lex111 lex111 requested a review from slorber as a code owner March 10, 2021 18:26
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 10, 2021
@netlify
Copy link

netlify bot commented Mar 10, 2021

[V1] Deploy preview success

Built with commit bb865e1

https://deploy-preview-4383--docusaurus-1.netlify.app

@github-actions
Copy link

Size Change: 0 B

Total Size: 564 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.3 kB 0 B
website/build/assets/js/main.********.js 390 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.7 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.6 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Mar 10, 2021

Deploy preview for docusaurus-2 ready!

Built with commit bb865e1

https://deploy-preview-4383--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4383--docusaurus-2.netlify.app/classic/

@slorber
Copy link
Collaborator

slorber commented Mar 10, 2021

seems like a little improvement

but I think what the user does is kind of an antipattern and he should rather use css for theming to avoid FOUC

image

@slorber slorber merged commit 6afa83c into master Mar 10, 2021
@lex111 lex111 added this to the v2.0.0-alpha.72 milestone Mar 15, 2021
This was referenced Mar 17, 2021
This was referenced Mar 17, 2021
@slorber slorber deleted the lex111/color-mode-default-ssr branch August 17, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants