Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): add missing peer dep on @babel/core #4424

Merged
merged 1 commit into from
Mar 15, 2021
Merged

fix(v2): add missing peer dep on @babel/core #4424

merged 1 commit into from
Mar 15, 2021

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Mar 13, 2021

Motivation

image

Have you read the Contributing Guidelines on pull requests?

Yup!

Test Plan

Adding

packageExtensions:
  "@docusaurus/plugin-pwa@*":
    peerDependencies:
      "@babel/core": "^7.0.0"

removes the warning

Related PRs

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 13, 2021
@netlify
Copy link

netlify bot commented Mar 13, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit cfa8ec4

https://deploy-preview-4424--docusaurus-2.netlify.app

@netlify
Copy link

netlify bot commented Mar 14, 2021

[V1] Deploy preview failure

Built without sensitive environment variables with commit cfa8ec4

https://app.netlify.com/sites/docusaurus-1/deploys/604cb897ab87570007444eb6

@slorber slorber added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: bug fix This PR fixes a bug in a past release. and removed pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Mar 15, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 15, 2021

👍

@slorber slorber changed the title fix(pwa-plugin): add missing peer dep on @babel/core fix(v2): add missing peer dep on @babel/core Mar 15, 2021
@slorber slorber merged commit 9a33802 into facebook:master Mar 15, 2021
@lex111 lex111 added this to the v2.0.0-alpha.72 milestone Mar 15, 2021
This was referenced Mar 17, 2021
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Merged
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
@SimenB SimenB deleted the patch-1 branch March 24, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

@slorber slorber Awaiting requested review from slorber

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
v2.0.0-alpha.72
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SimenB @slorber @lex111 @facebook-github-bot