fix(v2): allow using pre tag in Markdown directly #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview success Built with commit a84aeb5 |
|
Size Change: 0 B Total Size: 567 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built with commit a84aeb5 |
|
LGTM thanks 👍 |
This was referenced Mar 17, 2021
Closed
Merged
This was referenced Mar 17, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #4315 a small regression was made related with using of
<pre>tag in Markdown markup. Usually it is not necessary to use this tag, but legacy content pages (e.g., when migrating from other platforms) can contains it.However, when using pre in the MDX will be removed all line breaks (see mdx-js/mdx#1095). So it shouldn't be used anyway and users will have to use triple backtick or CodeBlock component to proper formatting of code blocks.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)