chore: fix GH actions lint problem matchers issue in PR

[slorber]

Motivation

With #4447 we now lint on Github Actions and also use setup-node actions, enabling GH actions "problem matchers".

The problem is that now each PR has a list of reported lint errors in the files tab, like here: https://github.com/facebook/docusaurus/pull/4468/files

This is distracting PR reviews, so I'm using eslint --quiet option to ensure we don't care about warnings in CI and they don't end up in the PR.

cc @SamChou19815 , any alternative to suggest?

[netlify]

[V1] Deploy preview failure

Built with commit 7886815

https://app.netlify.com/sites/docusaurus-1/deploys/6054dd0b745bda00072744b6

[netlify]

Deploy preview for docusaurus-2 ready!

Built with commit 7886815

https://deploy-preview-4471--docusaurus-2.netlify.app

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	84
🟢 Accessibility	96
🟢 Best practices	100
🟢 SEO	100
🟢 PWA	95

Lighthouse ran on https://deploy-preview-4471--docusaurus-2.netlify.app/

[SamChou19815]

I think the point of the problem matcher is that we can see the lint warnings more easily, but I agree that the warnings on unchanged files can be annoying. Maybe we can try to lint only changed files on CI?

e.g. https://gist.github.com/seeliang/0f0de424d1cdc4541c338f4ee93b7e6a

[github-actions]

Size Change: 0 B

Total Size: 575 kB

ℹ️ View Unchanged

Filename	Size	Change
website/build/assets/css/styles.********.css	87.2 kB	0 B
website/build/assets/js/main.********.js	401 kB	0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html	60.8 kB	0 B
website/build/docs/introduction/index.html	235 B	0 B
website/build/index.html	25.7 kB	0 B

_{compressed-size-action}

[slorber]

Thanks, that's an idea but I think it's still useful to run on everything, at least on master.

Will merge this for now to reduce the noise, but that could be nice to have relevant warnings show in the PRs indeed :)

[armano2]

maybe we should just fix those warnings instead of hiding them?

[slorber]

maybe we should just fix those warnings instead of hiding them?

make sense, and we could re-enable the non-quiet CI linter.

There are 55 lint warnings left, do you want to fix those?

[slorber]

maybe sync with @SamChou19815 as he did some cleanup recently and may already working on the last warnings?

[SamChou19815]

@armano2 I'm not in the middle of fixing them right now. I'm currently trying to integrate esbuild into docusaurus.