Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify CI setup #4447

Merged
merged 18 commits into from
Mar 18, 2021
Merged

chore: simplify CI setup #4447

merged 18 commits into from
Mar 18, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 17, 2021

Motivation

We have tests and lint running on CircleCI while most of the other things are on GH actions: let's move everything to GH actions as it's simpler and better integrated to Git.

(The v1 site remains deployed with CircleCI for now, until we switch to v1.docusaurus.io that is already on Netlify)

The linter does not lint the docs correctly.

The Netlify deploy preview builds too many previews and takes too much time, and block merges, while we often don't need to check the alternative deploys.

Let's just deploy the v2 site, and move alternate deploys to GH actions. I think just building the alternate deploys is good enough and we don't really need a preview anyway, until we have a real theme gallery.

Also:

  • use paths to filter PR executions
  • use more consistent action names
  • fix v1 test race-condition issues becoming visible after migrating tests to GH actions

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 17, 2021
@slorber slorber requested a review from lex111 as a code owner March 17, 2021 17:14
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 17, 2021
@netlify
Copy link

netlify bot commented Mar 17, 2021

[V1] Deploy preview success

Built with commit b49ebe3

https://deploy-preview-4447--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Mar 17, 2021

Deploy preview for docusaurus-2 ready!

Built with commit b49ebe3

https://deploy-preview-4447--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 17, 2021

Size Change: 0 B

Total Size: 575 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.2 kB 0 B
website/build/assets/js/main.********.js 401 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.8 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.7 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants