Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fixed broken link in sidebar documentation #4472

Merged
merged 1 commit into from
Mar 19, 2021
Merged

docs(v2): fixed broken link in sidebar documentation #4472

merged 1 commit into from
Mar 19, 2021

Conversation

idontknowjs
Copy link
Contributor

Issue

The Sidebar Object Section contains a statement: greeting and doc1 are both sidebar item.
Here the sidebar item links to broken URL ie. https://v2.docusaurus.io/docs/sidebar#sidebar-item
image

Fix

Updated the link with https://v2.docusaurus.io/docs/sidebar#understanding-sidebar-items

Have you read the Contributing Guidelines on pull requests?

Yes.

@netlify
Copy link

netlify bot commented Mar 19, 2021

@netlify
Copy link

netlify bot commented Mar 19, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 5243113

https://deploy-preview-4472--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 80
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4472--docusaurus-2.netlify.app/

@slorber
Copy link
Collaborator

slorber commented Mar 19, 2021

LGTM, just need the CLA signature bot check

@facebook-github-bot
Copy link
Contributor

Hi @CovalentBond!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 19, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@idontknowjs
Copy link
Contributor Author

@slorber can you please review now, thanks in advance!

@lex111 lex111 merged commit 9bdb9eb into facebook:master Mar 19, 2021
@lex111
Copy link
Contributor

lex111 commented Mar 19, 2021

@CovalentBond thanks!

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 19, 2021
@idontknowjs idontknowjs deleted the patch-1 branch March 19, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants