-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): fixed broken link in sidebar documentation #4472
Conversation
[V1] Deploy preview failure Built without sensitive environment variables with commit 5243113 https://app.netlify.com/sites/docusaurus-1/deploys/6054ded3b544b80008083212 |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 5243113 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4472--docusaurus-2.netlify.app/ |
LGTM, just need the CLA signature bot check |
Hi @CovalentBond! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@slorber can you please review now, thanks in advance! |
@CovalentBond thanks! |
Issue
The Sidebar Object Section contains a statement:
![image](https://user-images.githubusercontent.com/53327173/111817841-83db6480-8904-11eb-9582-8a101db0dae8.png)
greeting and doc1 are both sidebar item
.Here the sidebar item links to broken URL ie. https://v2.docusaurus.io/docs/sidebar#sidebar-item
Fix
Updated the link with https://v2.docusaurus.io/docs/sidebar#understanding-sidebar-items
Have you read the Contributing Guidelines on pull requests?
Yes.