Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix grammar and improve wording #4481

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

aehrea
Copy link
Contributor

@aehrea aehrea commented Mar 21, 2021

  • resolve grammar issue in Setup heading and rephrase to (subjectively) more clear wording (L50, L55)
  • more consistent wording in first line of Versioned paths heading (L143)

Motivation

fix grammar issues and improve wording in https://v2.docusaurus.io/docs/docs-multi-instance

L50/55: grammar errors
L143: clarify each plugin instance ...; doing so also matches the wording used under "Tagging new versions" (L167)

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

- resolve grammar issue in Setup heading and rephrase to (subjectively) more clear wording
- more consistent wording in first line of Versioned paths heading
@facebook-github-bot
Copy link
Contributor

Hi @aehrea!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Mar 21, 2021

@aehrea
Copy link
Contributor Author

aehrea commented Mar 21, 2021

Let me know if there's anything against it but as I'd prefer to stay anonymous the CLA was signed with a pseudonym.

@netlify
Copy link

netlify bot commented Mar 21, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit e785a37

https://deploy-preview-4481--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4481--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 21, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@aehrea aehrea changed the title docs: fix grammar and improve wording docs(v2): fix grammar and improve wording Mar 21, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 22, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 22, 2021

thanks :)

@slorber slorber merged commit 3c165c3 into facebook:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants