feat(v2): add pt-PT translations for docusaurus-theme-classic #4536
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 77e3217 https://app.netlify.com/sites/docusaurus-1/deploys/6062e3163be0310007d55b6a |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit bf36662 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4536--docusaurus-2.netlify.app/ |
|
thanks! |
|
Was wondering, if a user choose locale = "pt", should we apply PT or BR translations by default? |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 77e3217 |
|
That is actually a good question! If you think with maths, it would probably be better to use pt-BR, since there are waaaay more brazilian people than portuguese people, however pt-PT is the "original" ahahah If I had to choose only one, maybe pt-BR, since it more probable that someone would brazilian rather than portuguese. |
|
I see Maybe we should have |
|
Yeah, that's probably the best approach, since I believe most brazilian people are more used to seeing "pt-BR" than simply "pt". |
|
Apparently, it's pt-BR :) https://twitter.com/sebastienlorber/status/1376825837417340931
|
|
Fair enough then, we learn things every day ahahah |
|
"pt" -> "pt-BR" implemented in #4581 |
Motivation
Following this comment asking if it was possible to also have the translation for pt-PT translations, I wanted to help.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Since I only added a new translation JSON, there is no test plan, the existing tests should do fine.
Related PRs
None