Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix run-on sentence #4543

Merged
merged 5 commits into from
Apr 1, 2021
Merged

docs(v2): fix run-on sentence #4543

merged 5 commits into from
Apr 1, 2021

Conversation

duanwilliam
Copy link
Contributor

@duanwilliam duanwilliam commented Apr 1, 2021

Motivation

Minor run-on sentence in the docs under CLI commands on swizzle.

Have you read the Contributing Guidelines on pull requests?

yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 1, 2021
@duanwilliam duanwilliam changed the title docs: fix run-on sentence docs(v2): fix run-on sentence Apr 1, 2021
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4543--docusaurus-2.netlify.app/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 1, 2021
@slorber
Copy link
Collaborator

slorber commented Apr 1, 2021

👍

@slorber
Copy link
Collaborator

slorber commented Apr 1, 2021

For some reason the Netlify CI (required to merge) refuses to report a successful build.

I think it's a bug, can you please re-open a similar pr?

@slorber
Copy link
Collaborator

slorber commented Apr 1, 2021

so, our Github / Netlify has some serious problems, there's nothing you can do.

Let's keep this PR open and I'll merge it when I can 😅

@slorber
Copy link
Collaborator

slorber commented Apr 1, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 8bc429d

https://deploy-preview-4543--docusaurus-2.netlify.app

@slorber slorber merged commit 51031c1 into facebook:master Apr 1, 2021
@duanwilliam duanwilliam deleted the patch-1 branch April 1, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants