Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add a missing "export" from the initial template #4546

Conversation

Foxeye-Rinx
Copy link
Contributor

@Foxeye-Rinx Foxeye-Rinx commented Apr 1, 2021

Motivation

Improve the initial template
For now, if a new user creates the project using the CLI, it opens at http://localhost:3000.
It is convenience for the user to continue reading at the guide that already shows on http://localhost:3000.
But it's missing an" export" command on the guide and it makes the guide doesn't work.
This commit is consistent with the official guide at https://docusaurus.io/docs/creating-pages (current version: 2.0.0-alpha.72)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No

Related PRs

#4320

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 1, 2021
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 67
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4546--docusaurus-2.netlify.app/

@slorber
Copy link
Collaborator

slorber commented Apr 2, 2021

Thanks, I'm going to expert the fn directly :)

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 2, 2021
@netlify
Copy link

netlify bot commented Apr 2, 2021

[V1]

Built with commit a2613fb

https://deploy-preview-4546--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Apr 2, 2021

[V2]

Built with commit a2613fb

https://deploy-preview-4546--docusaurus-2.netlify.app

@slorber slorber merged commit 9fceeb9 into facebook:master Apr 2, 2021
@Foxeye-Rinx Foxeye-Rinx deleted the docs(v2)-add-missing-export-from-initial-template-instruction branch April 2, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants